r92625 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92624‎ | r92625 | r92626 >
Date:11:30, 20 July 2011
Author:ashley
Status:ok
Tags:
Comment:
SocialPrSocialProfile: follow-up to r92621: remove DIY avatar code from UserGifts (and tweak spacing). I wonder if all instances of that code are now gone...
Modified paths:
  • /trunk/extensions/SocialProfile/UserGifts/SpecialViewGift.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserGifts/SpecialViewGift.php
@@ -70,9 +70,6 @@
7171 $removeGiftLink = SpecialPage::getTitleFor( 'RemoveGift' );
7272 $giveGiftLink = SpecialPage::getTitleFor( 'GiveGift' );
7373
74 - $avatar = new wAvatar( $gift['user_id_from'], 's' );
75 - $avatar_img = '<img src="' . $wgUploadPath . '/avatars/' .
76 - $avatar->getAvatarImage() . '" alt="" border="0" />';
7774 $giftImage = '<img src="' . $wgUploadPath . '/awards/' .
7875 Gifts::getGiftImage( $gift['gift_id'], 'l' ) .
7976 '" border="0" alt="" />';
@@ -80,8 +77,8 @@
8178 $message = $wgOut->parse( trim( $gift['message'] ), false );
8279
8380 $output .= '<div class="g-description-container">';
84 - $output .= '<div class="g-description">'
85 - . $giftImage .
 81+ $output .= '<div class="g-description">' .
 82+ $giftImage .
8683 '<div class="g-name">' . $gift['name'] . '</div>
8784 <div class="g-timestamp">(' . $gift['timestamp'] . ')</div>
8885 <div class="g-from">' . wfMsg(
@@ -98,9 +95,7 @@
9996 <a href="' . $giveGiftLink->escapeFullURL( 'gift_id=' . $gift['gift_id'] ) . '">' .
10097 wfMsg( 'g-to-another' ) . '</a>';
10198 if ( $gift['user_name_to'] == $wgUser->getName() ) {
102 - $output .= '&nbsp';
10399 $output .= wfMsgExt( 'pipe-separator', 'escapenoentities' );
104 - $output .= '&#160;';
105100 $output .= '<a href="' . $removeGiftLink->escapeFullURL( 'gift_id=' . $gift['id'] ) . '">' .
106101 wfMsg( 'g-remove-gift' ) . '</a>';
107102 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92621SocialProfile: since we already have a wAvatar object available, use its getA...ashley10:49, 20 July 2011

Status & tagging log