r92612 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92611‎ | r92612 | r92613 >
Date:08:40, 20 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Cleaned up mwversionsinuse bash script (committed by accident in r92611)
Modified paths:
  • /trunk/tools/mwmultiversion/scripts/mwversionsinuse (modified) (history)

Diff [purge]

Index: trunk/tools/mwmultiversion/scripts/mwversionsinuse
@@ -1,12 +1,12 @@
22 #!/bin/sh
3 -# Returns a space separated list of all active MW versions (e.g. x.xx).
 3+# Returns a space separated list of all active MW versions (e.g. "x.xx").
44 # This script belongs in /usr/bin/ and should be in PATH.
55 declare -a mwVersionsionNums
66 while read line
77 do
88 mwVersion=${line#* }
99 mwVersionNum=${mwVersion#*-}
10 - if [ -n "$mwVersion" -a -n "$mwVersionNum" ]; then
 10+ if [ -n "$mwVersionNum" ]; then
1111 mwVersionInArray=0
1212 for i in "${mwVersionsionNums[@]}"
1313 do
@@ -15,11 +15,10 @@
1616 break
1717 fi
1818 done
19 - if [ mwVersionInArray -eq 0 ]; then
20 - mwVersionsionNums=("${mwVersionsionNums[@]}" mwVersionNum)
 19+ if [ $mwVersionInArray -eq 0 ]; then
 20+ mwVersionsionNums=("${mwVersionsionNums[@]}" "$mwVersionNum")
2121 fi
2222 else
23 - echo ""
2423 exit 1
2524 fi
2625 done < /usr/local/apache/common-local/wmf-config/wikiversions.cdb

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92611* Added MWMultiVersion::getVersionNumber method and use it for various dirs (...aaron08:14, 20 July 2011

Status & tagging log