r92560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92559‎ | r92560 | r92561 >
Date:19:53, 19 July 2011
Author:platonides
Status:resolved (Comments)
Tags:
Comment:
Remove double ; and final ?> from jsminplus (imported in r91591).
This should be uncontroversial.
Modified paths:
  • /trunk/phase3/includes/libs/jsminplus.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/jsminplus.php
——@@ -1536,7 +1536,7 @@
15371537
15381538 if (($numargs = func_num_args()) > 2)
15391539 {
1540 - $args = func_get_args();;
 1540+ $args = func_get_args();
15411541 for ($i = 2; $i < $numargs; $i++)
15421542 $this->addNode($args[$i]);
15431543 }
——@@ -1977,4 +1977,4 @@
19781978 public $assignOp;
19791979 }
19801980
1981 -?>
\ No newline at end of file
 1981+?>

Follow-up revisions

RevisionCommit summaryAuthorDate
r92586Merge code cleanup revisions so that code analysis can also be performed in t...platonides21:29, 19 July 2011
r93020Update JSMin+ to the newly released 1.4...platonides21:46, 24 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91591Followup r83885: add JSMin+ 1.3 to use its parser to verify output of JavaScr...brion20:02, 6 July 2011

Comments

#Comment by Reedy (talk | contribs)   20:14, 19 July 2011

The ?> is still there...

#Comment by Platonides (talk | contribs)   20:16, 19 July 2011

Got really removed in r92563

#Comment by Nikerabbit (talk | contribs)   08:47, 20 July 2011

What's the benefit if this isn't fixed in the upstream?

#Comment by Platonides (talk | contribs)   17:25, 20 July 2011

Avoiding warnings for this file. I would of corsue like having it upstream (this change should be uncontroversial), that's why I mentioned it in my mail to Tino.

#Comment by Brion VIBBER (talk | contribs)   17:49, 20 July 2011

Unnecessary divergence from upstream version of library. Recommend revert.

#Comment by Platonides (talk | contribs)   17:45, 22 July 2011

We are forking it with r92563 anyway. I'd prefer to wait for the answer from upstream. If he accepts both changes, only one or none.

#Comment by Platonides (talk | contribs)   21:47, 24 July 2011

This has been included into JSMin+ 1.4 [1]

Status & tagging log