r92508 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92507‎ | r92508 | r92509 >
Date:23:27, 18 July 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Added fallback to current selection/location back into insert/delete/annotate functions (fixes failed merge)
Modified paths:
  • /trunk/parsers/wikidom/lib/es/es.Surface.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/es/es.Surface.js
@@ -627,21 +627,12 @@
628628 * @param selection {Selection} Range to apply annotation to
629629 */
630630 Surface.prototype.annotateContent = function( method, annotation, selection ) {
631 -<<<<<<< .mine
632631 if ( typeof selection === 'undefined' ) {
633632 selection = this.selection;
634633 }
635634 if ( !selection.from || !selection.to ) {
636 -=======
637 - if ( selection === undefined ) {
638 - selection = this.selection;
639 - }
640 - /*
641 - if ( !selection.from && !selection.to ) {
642 ->>>>>>> .r92506
643635 throw 'Invalid selection error. Properties for from and to locations expected.';
644636 }
645 - */
646637 selection.normalize();
647638 var from = selection.start,
648639 to = selection.end;

Status & tagging log