r92420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92419‎ | r92420 | r92421 >
Date:00:26, 18 July 2011
Author:yaron
Status:deferred
Tags:
Comment:
Follow-up to r92410 and r92417 - this is the wrong place for any sort of HTML-escaping
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -806,8 +806,6 @@
807807 } elseif ( array_key_exists( $field_name, $template_instance_query_values ) ) {
808808 $field_query_val = $template_instance_query_values[$field_name];
809809 }
810 - // Escaping of quotes is necessary.
811 - $field_query_val = str_replace( '"', '"', $field_query_val );
812810 if ( $form_submitted || ( ! empty( $field_query_val ) && ! is_array( $field_query_val ) ) ) {
813811 $cur_value = $field_query_val;
814812 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92410Fixed some formatting, and added HTML-escaping of values from query string, s...yaron20:42, 17 July 2011
r92417Partial revert of r92410 - removed HTML-escaping; this is the wrong place for ityaron22:45, 17 July 2011