r92414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92413‎ | r92414 | r92415 >
Date:21:11, 17 July 2011
Author:reedy
Status:ok
Tags:
Comment:
Improve documentation, remove unused global
Modified paths:
  • /trunk/extensions/Math/Math.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Math/Math.hooks.php
@@ -25,7 +25,7 @@
2626 /**
2727 * Register the <math> tag with the Parser.
2828 *
29 - * @param $parser Object: instance of Parser
 29+ * @param $parser Parser instance of Parser
3030 * @return Boolean: true
3131 */
3232 static function onParserFirstCallInit( $parser ) {
@@ -57,7 +57,6 @@
5858 * @return Boolean: true
5959 */
6060 static function onGetPreferences( $user, &$defaultPreferences ) {
61 - global $wgLang;
6261 $defaultPreferences['math'] = array(
6362 'type' => 'radio',
6463 'options' => array_flip( array_map( 'wfMsgHtml', self::getMathNames() ) ),
@@ -101,7 +100,7 @@
102101 /**
103102 * LoadExtensionSchemaUpdates handler; set up math table on install/upgrade.
104103 *
105 - * @param $updater DatabaseUpdater
 104+ * @param $updater DatabaseUpdater
106105 * @return bool
107106 */
108107 static function onLoadExtensionSchemaUpdates( $updater = null ) {
@@ -116,7 +115,6 @@
117116 'mssql' => 'math.mssql.sql',
118117 'db2' => 'math.db2.sql',
119118 );
120 - $base = dirname( __FILE__ );
121119 $type = $updater->getDB()->getType();
122120 if ( isset( $map[$type] ) ) {
123121 $sql = dirname( __FILE__ ) . '/db/' . $map[$type];

Status & tagging log