r92297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92296‎ | r92297 | r92298 >
Date:20:24, 15 July 2011
Author:diebuche
Status:resolved (Comments)
Tags:
Comment:
r92288 : Missed second arg to inArray
Modified paths:
  • /trunk/phase3/resources/mediawiki.page/mediawiki.page.ajaxCategories.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.page/mediawiki.page.ajaxCategories.js
@@ -44,7 +44,7 @@
4545
4646 var _saveAllButton;
4747 var _cancelAllButton;
48 - var _multiEdit = mw.util.inArray( mw.config.get( 'wgUserGroups' ) );
 48+ var _multiEdit = mw.util.inArray( mw.config.get( 'wgUserGroups' ), 'user' );
4949
5050 /**
5151 * Helper function for $.fn.suggestion

Follow-up revisions

RevisionCommit summaryAuthorDate
r92752Remove mw.util.inArray...krinkle16:41, 21 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92288ajaxCategories fixes:...krinkle19:25, 15 July 2011

Comments

#Comment by Krinkle (talk | contribs)   20:26, 15 July 2011

I won't say anything. 'user' is an interesting array.

Can you join IRC by the way ?

#Comment by Krinkle (talk | contribs)   16:44, 21 July 2011

Item argument must be before the array argument (try it in the console), fixed in r92752

#Comment by DieBuche (talk | contribs)   16:48, 21 July 2011

Did you get my mail?

#Comment by Krinkle (talk | contribs)   16:52, 21 July 2011

Yes

Status & tagging log