r92278 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92277‎ | r92278 | r92279 >
Date:19:01, 15 July 2011
Author:reedy
Status:ok
Tags:
Comment:
1.17wmf1 MFT r82748, r87840, r89401, r89697
Modified paths:
  • /branches/wmf/1.17wmf1/includes/libs/CSSMin.php (modified) (history)
  • /branches/wmf/1.17wmf1/resources/Resources.php (modified) (history)
  • /branches/wmf/1.17wmf1/skins/common/commonPrint.css (modified) (history)
  • /branches/wmf/1.17wmf1/skins/common/shared.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/skins/common/commonPrint.css
@@ -232,31 +232,35 @@
233233
234234 #siteNotice { display: none; }
235235
236 -/* image galleries */
237 -table.gallery {
238 - border: 1px solid #ccc;
239 - margin: 2px;
240 - padding: 2px;
241 - background-color: white;
242 - border-collapse: collapse;
243 -}
244 -
245 -table.gallery tr {
 236+/* Galleries (see shared.css for more info) */
 237+li.gallerybox {
246238 vertical-align: top;
 239+ background-color: #f9f9f9;
 240+ border: solid 2px white;
 241+ display: -moz-inline-box;
 242+ display: inline-block;
247243 }
248244
249 -table.gallery td {
250 - vertical-align: top;
251 - padding: 1px;
252 - border: 1px solid #ccc;
 245+ul.gallery, li.gallerybox {
 246+ zoom: 1;
 247+ *display: inline;
253248 }
254249
255 -div.gallerybox {
 250+ul.gallery {
256251 margin: 2px;
 252+ padding: 2px;
 253+ display: block;
257254 }
258255
259 -div.gallerybox div.thumb {
 256+li.gallerycaption {
 257+ font-weight: bold;
260258 text-align: center;
 259+ display: block;
 260+ word-wrap: break-word;
 261+}
 262+
 263+li.gallerybox div.thumb {
 264+ text-align: center;
261265 border: 1px solid #ccc;
262266 margin: 2px;
263267 }
@@ -265,8 +269,8 @@
266270 overflow: hidden;
267271 font-size: 94%;
268272 padding: 2px 4px;
 273+ word-wrap: break-word;
269274 }
270 -
271275 /*
272276 ** Diff rendering
273277 */
Index: branches/wmf/1.17wmf1/skins/common/shared.css
@@ -748,6 +748,7 @@
749749
750750 /* Galleries */
751751 /* These display attributes look nonsensical, but are needed to support IE and FF2 */
 752+/* Don't forget to update commonPrint.css */
752753 li.gallerybox {
753754 vertical-align: top;
754755 background-color: #f9f9f9;
@@ -764,7 +765,6 @@
765766 ul.gallery {
766767 margin: 2px;
767768 padding: 2px;
768 - background-color: white;
769769 display: block;
770770 }
771771
Property changes on: branches/wmf/1.17wmf1/skins/common/shared.css
___________________________________________________________________
Modified: svn:mergeinfo
772772 Merged /trunk/phase3/skins/common/shared.css:r82748,87840,89401,89697
Index: branches/wmf/1.17wmf1/includes/libs/CSSMin.php
@@ -120,8 +120,9 @@
121121 self::URL_REGEX . '(?P<post>[^;]*)[\;]?/';
122122 $offset = 0;
123123 while ( preg_match( $pattern, $source, $match, PREG_OFFSET_CAPTURE, $offset ) ) {
124 - // Skip absolute URIs
125 - if ( preg_match( '/^https?:\/\//', $match['file'][0] ) ) {
 124+ // Skip fully-qualified URLs and data URIs
 125+ $urlScheme = parse_url( $match['file'][0], PHP_URL_SCHEME );
 126+ if ( $urlScheme ) {
126127 // Move the offset to the end of the match, leaving it alone
127128 $offset = $match[0][1] + strlen( $match[0][0] );
128129 continue;
Index: branches/wmf/1.17wmf1/resources/Resources.php
@@ -78,6 +78,7 @@
7979 'jquery.suggestions' => array(
8080 'scripts' => 'resources/jquery/jquery.suggestions.js',
8181 'styles' => 'resources/jquery/jquery.suggestions.css',
 82+ 'dependencies' => 'jquery.autoEllipsis',
8283 ),
8384 'jquery.tabIndex' => array(
8485 'scripts' => 'resources/jquery/jquery.tabIndex.js'
Property changes on: branches/wmf/1.17wmf1/resources/Resources.php
___________________________________________________________________
Modified: svn:mergeinfo
8586 Merged /trunk/phase3/resources/Resources.php:r89401,89697

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82748Removed white-background from ul.gallery; Updated commonPrint gallery styles...krinkle21:16, 24 February 2011
r87840* (bug 25262) Fix for minification of hardcoded data: URIs in CSS...brion20:14, 10 May 2011
r89401(bug 29121) jquery.suggestions uses jquery.autoEllipsis but didn't have it in...catrope09:51, 3 June 2011
r89697Fix (bug 29307) Line-height in <pre> is too narrow, edges overlap in some env...krinkle21:39, 7 June 2011

Status & tagging log