r92255 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92254‎ | r92255 | r92256 >
Date:17:34, 15 July 2011
Author:brion
Status:ok
Tags:
Comment:
followup r92253: revert accidental commit of test code
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.localize.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.localize.js
@@ -12,16 +12,14 @@
1313 mw.messages.set( 'basic', 'Basic stuff' );
1414
1515 // Tag: html:msg
16 - html = '<div><span><html:msg key="basic"/></span></div>';
 16+ html = '<div><span><html:msg key="basic"></span></div>';
1717 $lc = $( html ).localize().find( 'span' );
18 - console.log($lc.length);
1918
2019 strictEqual( $lc.text(), 'Basic stuff', 'Tag: html:msg' );
2120
2221 // Tag: msg (deprecated)
23 - html = '<div><span><msg key="basic"/></span></div>';
 22+ html = '<div><span><msg key="basic"></span></div>';
2423 $lc = $( html ).localize().find( 'span' );
25 - $('body').append($lc);
2624
2725 strictEqual( $lc.text(), 'Basic stuff', 'Tag: msg' );
2826
@@ -48,7 +46,7 @@
4947 // making sure it is actually using text() and attr() (or something with the same effect)
5048
5149 // Text escaping
52 - html = '<div><span><html:msg key="properfoo"/></span></div>';
 50+ html = '<div><span><html:msg key="properfoo"></span></div>';
5351 $lc = $( html ).localize().find( 'span' );
5452
5553 strictEqual( $lc.text(), mw.msg( 'properfoo' ), 'Content is inserted as text, not as html.' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92253Revert r92238: partial addition of broken test cases to qunit test suite; loa...brion17:29, 15 July 2011

Status & tagging log