r92077 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92076‎ | r92077 | r92078 >
Date:18:33, 13 July 2011
Author:brion
Status:ok
Tags:
Comment:
* (bug 29592) WebChat extension iframe width fix: let the width fit the window rather than hardcoding based on screen width

Applied patch submitted by Maymond Martineau, with comments removed: https://bugzilla.wikimedia.org/attachment.cgi?id=8708
Modified paths:
  • /trunk/extensions/WebChat/WebChat_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WebChat/WebChat_body.php
@@ -37,7 +37,7 @@
3838 $query = implode( $query, '&' );
3939
4040 $wgOut->addHTML( Xml::openElement( 'iframe', array(
41 - 'width' => '600',
 41+ 'width' => '100%',
4242 'height' => '500',
4343 'scrolling' => 'no',
4444 'border' => '0',
@@ -51,9 +51,7 @@
5252 '/* <![CDATA[ */
5353 function webChatExpand( elem ) {
5454 height = elem.height;
55 - width = elem.width;
5655 elem.height = screen.height - 500;
57 - elem.width = screen.width - 250;
5856 }
5957 /* ]]> */'
6058 ) );

Status & tagging log