r92053 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92052‎ | r92053 | r92054 >
Date:10:34, 13 July 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
small style improvements
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -17,8 +17,6 @@
1818 * @author Sanyam Goyal
1919 * @author Jeroen De Dauw
2020 * @author Devayon Das
21 - *
22 - *
2321 */
2422 class SMWQueryCreatorPage extends SMWQueryUI {
2523
@@ -63,7 +61,7 @@
6462 * @global booolean $smwgQSortingSupport
6563 * @return string
6664 *
67 - * TODO: clean up the lines handling sorting
 65+ * @todo Clean up the lines handling sorting.
6866 */
6967 protected function makeResults() {
7068 global $wgOut;
@@ -111,22 +109,21 @@
112110
113111 }
114112
115 - /**
116 - * Compatibility method to get the skin; MW 1.18 introduces a getSkin method in SpecialPage.
117 - *
118 - * @since 1.6
119 - *
120 - * @return Skin
121 - */
122 - public function getSkin() {
123 - if ( method_exists( 'SpecialPage', 'getSkin' ) ) {
124 - return parent::getSkin();
 113+ /**
 114+ * Compatibility method to get the skin; MW 1.18 introduces a getSkin method in SpecialPage.
 115+ *
 116+ * @since 1.6
 117+ *
 118+ * @return Skin
 119+ */
 120+ public function getSkin() {
 121+ if ( method_exists( 'SpecialPage', 'getSkin' ) ) {
 122+ return parent::getSkin();
 123+ } else {
 124+ global $wgUser;
 125+ return $wgUser->getSkin();
 126+ }
125127 }
126 - else {
127 - global $wgUser;
128 - return $wgUser->getSkin();
129 - }
130 - }
131128
132129 }
133130