r92047 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92046‎ | r92047 | r92048 >
Date:05:05, 13 July 2011
Author:nad
Status:deferred
Tags:
Comment:
had condition the wrong way round
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -285,11 +285,11 @@
286286 $re = preg_match( "|^[/#%]|", $b );
287287 switch ( $operator ) {
288288 case '=':
289 - $cond = $re ? preg_match( $b, $a ) : ( empty( $b ) ? ( $a == $b ) : true );
 289+ $cond = $re ? preg_match( $b, $a ) : ( empty( $b ) ? true : ( $a == $b ) );
290290 break;
291291
292292 case '!=':
293 - $cond = $re ? !preg_match( $b, $a ) : ( empty( $b ) ? ( $a != $b ) : true );
 293+ $cond = $re ? !preg_match( $b, $a ) : ( empty( $b ) ? true : ( $a != $b ) );
294294 break;
295295
296296 default:

Status & tagging log