r91936 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91935‎ | r91936 | r91937 >
Date:04:26, 12 July 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r91695, fixing wrong campaign ID bug
Modified paths:
  • /trunk/extensions/CentralNotice/special/SpecialCentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialCentralNotice.php
@@ -161,7 +161,7 @@
162162 $diffs = array_diff_assoc( $allInitialCampaignSettings[$campaignName], $finalCampaignSettings );
163163 // If there are changes, log them
164164 if ( $diffs ) {
165 - $campaignId = $this->getNoticeId( $notice );
 165+ $campaignId = $this->getNoticeId( $campaignName );
166166 $this->logCampaignChange( 'modified', $campaignId, $allInitialCampaignSettings[$campaignName], $finalCampaignSettings );
167167 }
168168 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91695Consolidate boolean campaign setting methods. Log the campaign setting change...kaldari22:10, 7 July 2011

Status & tagging log