r91902 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91901‎ | r91902 | r91903 >
Date:19:06, 11 July 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Using "end" instead of "stop" for consistency.
Modified paths:
  • /trunk/parsers/wikidom/tests/annotations/test.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/tests/annotations/test.js
@@ -76,14 +76,14 @@
7777 "type": "italic",
7878 "range": {
7979 "start": 0,
80 - "stop": 4
 80+ "end": 4
8181 }
8282 },
8383 {
8484 "type": "xlink",
8585 "range": {
8686 "start": 8,
87 - "stop": 14
 87+ "end": 14
8888 },
8989 "data": {
9090 "url": "http://www.a.com"
@@ -93,7 +93,7 @@
9494 "type": "bold",
9595 "range": {
9696 "start": 10,
97 - "stop": 14
 97+ "end": 14
9898 }
9999 }
100100 ]
@@ -105,14 +105,14 @@
106106 "type": "italic",
107107 "range": {
108108 "start": 11,
109 - "stop": 14
 109+ "end": 14
110110 }
111111 },
112112 {
113113 "type": "bold",
114114 "range": {
115115 "start": 20,
116 - "stop": 24
 116+ "end": 24
117117 }
118118 }
119119 ]
@@ -133,7 +133,7 @@
134134 for ( var j in line.annotations ) {
135135 var annotation = line.annotations[j];
136136
137 - for ( var k = annotation.range.start; k <= annotation.range.stop; k++ ) {
 137+ for ( var k = annotation.range.start; k <= annotation.range.end; k++ ) {
138138 line.content[k].push( annotation );
139139 }
140140 }

Status & tagging log