r91894 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91893‎ | r91894 | r91895 >
Date:18:14, 11 July 2011
Author:brion
Status:ok
Tags:
Comment:
Followup r91844: fix jquery.byteLimit test cases on IE6, IE7

str[i] doesn't work on these older browsers; use str.charAt(i) instead.
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.byteLimit.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.byteLimit.js
——@@ -19,7 +19,7 @@
2020 var event = new jQuery.Event( 'keypress', { keyCode: code, which: code, charCode: code } );
2121 $input.trigger( event );
2222 if ( !event.isDefaultPrevented() ) {
23 - $input.val( prevVal + charstr[i] );
 23+ $input.val( prevVal + charstr.charAt(i) );
2424 }
2525 }
2626 };

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91844Add test suite for jquery.byteLimit:...krinkle21:01, 10 July 2011

Status & tagging log