r91866 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91865‎ | r91866 | r91867 >
Date:09:17, 11 July 2011
Author:devayon
Status:deferred
Tags:
Comment:
style cleanup, uses getPOStrings()
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -23,10 +23,7 @@
2424 */
2525 class SMWQueryCreatorPage extends SMWQueryUI {
2626
27 - //protected $m_querystring = '';
2827 protected $m_params = array();
29 - //protected $m_printouts = array();
30 - //protected $m_editquery = false;
3128
3229 /**
3330 * Constructor.
@@ -45,7 +42,6 @@
4643 global $wgOut, $wgRequest, $smwgQEnabled;
4744
4845 $this->setHeaders();
49 -// var_dump(SpecialPage::getSafeTitleFor( 'Ask' )->getLocalURL( "showformatoptions" ));die;
5046
5147 if ( !$smwgQEnabled ) {
5248 $wgOut->addHTML( '<br />' . wfMsg( 'smw_iq_disabled' ) );
@@ -53,10 +49,10 @@
5450 if(!($this->processFormatOptions($wgRequest))){
5551 $params=array_merge(
5652 array(
57 - 'format' => $wgRequest->getVal( 'format', 'ol' ),
58 - 'offset' => $wgRequest->getVal( 'offset', '0' ),
59 - 'limit' => $wgRequest->getVal( 'limit', '20' )
60 - ),$this->processFormatSelectBox($wgRequest));
 53+ 'format' => $wgRequest->getVal( 'format' ),
 54+ 'offset' => $wgRequest->getVal( 'offset', '0' ),
 55+ 'limit' => $wgRequest->getVal( 'limit', '20' )
 56+ ),$this->processFormatSelectBox($wgRequest));
6157 $this->m_ui_helper = SMWQueryUIHelper::makeFromUI(
6258 $this->processQueryFormBox($wgRequest),
6359 $params,
@@ -113,7 +109,7 @@
114110 $result .= '<div id="additional_options" style="display:none">';
115111 $result .= '<p><strong>' . wfMsg( 'smw_ask_printhead' ) . "</strong></p>\n" .
116112 '<span style="font-weight: normal;">' . wfMsg( 'smw_ask_printdesc' ) . '</span>' . "\n" .
117 - '<p><textarea id = "add_property" name="po" cols="20" rows="6"></textarea></p>' . "\n";
 113+ '<p>'. $this->getPOFormBox($this->getPOStrings(),true).'</p>' . "\n";
118114
119115 // sorting inputs
120116 if ( $smwgQSortingSupport ) {