r91864 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91863‎ | r91864 | r91865 >
Date:08:46, 11 July 2011
Author:ialex
Status:ok
Tags:
Comment:
Call Linker methods statically and removed the $mSkin member
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
@@ -93,11 +93,6 @@
9494 public $mLimitsShown;
9595
9696 /**
97 - * @var Skin
98 - */
99 - protected $mSkin;
100 -
101 - /**
10297 * @var Language
10398 */
10499 public $lang;
@@ -138,7 +133,6 @@
139134 $this->displayPrefix = false;
140135 $this->prefix = false;
141136 }
142 - $this->getSkin();
143137
144138 // The suffix that may be needed for message names if we're in a
145139 // different language (eg [[MediaWiki:Foo/fr]]: $suffix = '/fr'
@@ -351,9 +345,9 @@
352346 $talk = Title::makeTitle( NS_MEDIAWIKI_TALK, $value . $this->suffix );
353347
354348 if( $this->mCurrentRow->am_customised ){
355 - $title = $this->mSkin->linkKnown( $title, $wgLang->lcfirst( $value ) );
 349+ $title = Linker::linkKnown( $title, $wgLang->lcfirst( $value ) );
356350 } else {
357 - $title = $this->mSkin->link(
 351+ $title = Linker::link(
358352 $title,
359353 $wgLang->lcfirst( $value ),
360354 array(),
@@ -362,9 +356,9 @@
363357 );
364358 }
365359 if ( $this->mCurrentRow->am_talk_exists ) {
366 - $talk = $this->mSkin->linkKnown( $talk , $this->talk );
 360+ $talk = Linker::linkKnown( $talk , $this->talk );
367361 } else {
368 - $talk = $this->mSkin->link(
 362+ $talk = Linker::link(
369363 $talk,
370364 $this->talk,
371365 array(),

Status & tagging log