r91808 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91807‎ | r91808 | r91809 >
Date:21:13, 9 July 2011
Author:robin
Status:ok
Tags:
Comment:
Bug 29792: notice undefined index 'other' due to my commit r91803
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
@@ -1375,7 +1375,7 @@
13761376
13771377 function __construct( $params ) {
13781378 if ( !in_array( 'other', $params['options'], true ) ) {
1379 - $msg = $params['other'] ? $params['other'] : wfMsg( 'htmlform-selectorother-other' );
 1379+ $msg = isset( $params['other'] ) ? $params['other'] : wfMsg( 'htmlform-selectorother-other' );
13801380 $params['options'][$msg] = 'other';
13811381 }
13821382

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91803Allow the 'other' parameter for HTMLForm selectorother: it is used in Special...robin19:33, 9 July 2011

Status & tagging log