r91764 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91763‎ | r91764 | r91765 >
Date:22:09, 8 July 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r91763
Modified paths:
  • /branches/wmf/1.17wmf1/maintenance/cleanupTable.inc (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/maintenance/cleanupTable.inc
@@ -101,7 +101,8 @@
102102 }
103103
104104 $table = $params['table'];
105 - $count = $dbr->selectField( $table, 'count(*)', $params['conds'], __METHOD__ );
 105+ // count(*) would melt the DB for huge tables, we can estimate here
 106+ $dbr->estimateRowCount( $table, '*', '', __METHOD__ );
106107 $this->init( $count, $table );
107108 $this->output( "Processing $table...\n" );
108109
Property changes on: branches/wmf/1.17wmf1/maintenance/cleanupTable.inc
___________________________________________________________________
Modified: svn:mergeinfo
109110 Merged /trunk/phase3/maintenance/cleanupTable.inc:r91763

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91763Use estimateRowCount() in CleanupTable rather than select count(*) which will...demon22:08, 8 July 2011

Status & tagging log