r91715 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91714‎ | r91715 | r91716 >
Date:07:02, 8 July 2011
Author:ialex
Status:ok
Tags:
Comment:
Follow-up r91657: missed this one
Modified paths:
  • /trunk/phase3/includes/RequestContext.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RequestContext.php
@@ -56,7 +56,7 @@
5757 * @return WebRequest
5858 */
5959 public function getRequest() {
60 - if ( !isset($this->request) ) {
 60+ if ( $this->request === null ) {
6161 global $wgRequest; # fallback to $wg till we can improve this
6262 $this->request = $wgRequest;
6363 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91657* Don't use isset() to check only for null...ialex17:42, 7 July 2011

Status & tagging log