r91687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91686‎ | r91687 | r91688 >
Date:21:07, 7 July 2011
Author:robin
Status:ok
Tags:
Comment:
Fix r91685: add space at the right place.
(Also removing unused variable in protectedtitles.)
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialProtectedtitles.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2516,7 +2516,7 @@
25172517 global $wgLang;
25182518 $dirmark = ( $oppositedm ? $wgLang->getDirMark( true ) : '' ) .
25192519 $wgLang->getDirMark();
2520 - $details = $details ? ' ' . $dirmark . "($details)" : '';
 2520+ $details = $details ? $dirmark . " ($details)" : '';
25212521 return $page . $details;
25222522 }
25232523
Index: trunk/phase3/includes/specials/SpecialProtectedtitles.php
@@ -92,8 +92,6 @@
9393
9494 $description_items[] = $protType;
9595
96 - $stxt = '';
97 -
9896 if ( $row->pt_expiry != 'infinity' && strlen($row->pt_expiry) ) {
9997 $expiry = $wgLang->formatExpiry( $row->pt_expiry );
10098
@@ -104,7 +102,7 @@
105103
106104 wfProfileOut( __METHOD__ );
107105
108 - return '<li>' . wfSpecialList( $link . $stxt, implode( $description_items, ', ' ) ) . "</li>\n";
 106+ return '<li>' . wfSpecialList( $link, implode( $description_items, ', ' ) ) . "</li>\n";
109107 }
110108
111109 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91685Bug #29752: add back a space that SPQRobin missed.mah20:58, 7 July 2011

Status & tagging log