r91684 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91683‎ | r91684 | r91685 >
Date:20:54, 7 July 2011
Author:hartman
Status:ok
Tags:
Comment:
One more fix for the for in loops.
Follow up to r91347
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
——@@ -107,7 +107,7 @@
108108 'div[rel="' + data.section + '"].section ' + 'div[rel="' + data.page + '"].page div'
109109 );
110110 var actions = $characters.data( 'actions' );
111 - for ( i = 0; data.character.length; i++ ) {
 111+ for ( i = 0; i < data.characters.length; i++ ) {
112112 // Character
113113 $characters
114114 .append(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91347Correct for in loops on arrays....hartman09:09, 2 July 2011

Status & tagging log