r91607 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91606‎ | r91607 | r91608 >
Date:21:35, 6 July 2011
Author:inez
Status:deferred
Tags:
Comment:
I think this is the correct implementation of extend function
Modified paths:
  • /trunk/parsers/wikidom/lib/es/es.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/es/es.js
@@ -22,7 +22,7 @@
2323 function extend( dst, src ) {
2424 var base = new src();
2525 for ( i in base ) {
26 - if ( typeof base[i] === 'function' && !( i in src.prototype ) ) {
 26+ if ( typeof base[i] === 'function' && !( i in dst.prototype ) ) {
2727 dst.prototype[i] = base[i];
2828 }
2929 }

Status & tagging log