r91598 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91597‎ | r91598 | r91599 >
Date:20:40, 6 July 2011
Author:aaron
Status:ok
Tags:
Comment:
* Removed isPatrollable(); unused
* Fixed comment
Modified paths:
  • /trunk/extensions/FlaggedRevs/dataclasses/FlaggedPage.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/dataclasses/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/dataclasses/FlaggedRevs.hooks.php
@@ -304,7 +304,7 @@
305305 $result = false;
306306 return false;
307307 }
308 - # Don't let users patrol pages not in $wgFlaggedRevsPatrolNamespaces
 308+ # Don't let users patrol reviewable pages (where reviewed <=> patrolled)
309309 } elseif ( $action === 'patrol' || $action === 'autopatrol' ) {
310310 $flaggedArticle = FlaggedPage::getTitleInstance( $title );
311311 # For a page to be patrollable it must not be reviewable.
Index: trunk/extensions/FlaggedRevs/dataclasses/FlaggedPage.php
@@ -247,17 +247,6 @@
248248 }
249249
250250 /**
251 - * Is this page in patrollable?
252 - * @return bool
253 - */
254 - public function isPatrollable() {
255 - if ( !FlaggedRevs::inPatrolNamespace( $this->mTitle ) ) {
256 - return false;
257 - }
258 - return !$this->isReviewable(); // pages that are reviewable are not patrollable
259 - }
260 -
261 - /**
262251 * Get the stable revision ID
263252 * @return int
264253 */

Status & tagging log