r91579 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91578‎ | r91579 | r91580 >
Date:18:30, 6 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Removed unused function param
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php
@@ -341,7 +341,7 @@
342342 // requesting the stable revision ("&stableid=x"), defer to override
343343 // behavior below, since it is the same as ("&stable=1").
344344 if ( $old ) {
345 - $this->showOldReviewedVersion( $srev, $frev, $tag, $prot );
 345+ $this->showOldReviewedVersion( $frev, $tag, $prot );
346346 $outputDone = true; # Tell MW that parser output is done
347347 $useParserCache = false;
348348 // Stable version requested by ID or relevant conditions met to
@@ -546,9 +546,7 @@
547547 * Tag output function must be called by caller
548548 * Parser cache control deferred to caller
549549 */
550 - protected function showOldReviewedVersion(
551 - FlaggedRevision $srev, FlaggedRevision $frev, &$tag, $prot
552 - ) {
 550+ protected function showOldReviewedVersion( FlaggedRevision $frev, &$tag, $prot ) {
553551 global $wgUser, $wgLang;
554552 $this->load();
555553 $flags = $frev->getTags();

Status & tagging log