r91559 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91558‎ | r91559 | r91560 >
Date:16:40, 6 July 2011
Author:ankitgarg833
Status:deferred
Tags:
Comment:
moving the Hooks logic to Extensions code.
small formatting fixes
Modified paths:
  • /trunk/extensions/PageSchemas/PageSchemas.classes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PageSchemas/PageSchemas.classes.php
——@@ -129,7 +129,7 @@
130130 $row = $dbr->fetchRow( $res );
131131 //retrievimg the third attribute which is pp_value
132132 $pageXmlstr = $row[2];
133 - $pageXml = simplexml_load_string ( $pageXmlstr );
 133+ $pageXml = simplexml_load_string ( $pageXmlstr );
134134 $this->pageName = (string)$pageXml->attributes()->name;
135135 /* index for template objects */
136136 $i = 0 ;
——@@ -144,20 +144,20 @@
145145 }
146146 }
147147 /* function to generate all pages based on the Xml contained in the page */
148 - function generateAllPages () {
 148+ function generateAllPages () {
149149 wfRunHooks( 'PageSchemasGeneratePages', array( $this ));
150150 }
151151 /*return an array of PSTemplate Objects */
152 - function getTemplates () {
 152+ function getTemplates () {
153153 return $this->PSTemplates;
154154 }
155155 /*returns the name of the PageSchema object */
156 - function getName(){
 156+ function getName(){
157157 return $this->pageName;
158158 }
159 - function getFormName(){
 159+ function getFormName(){
160160 return $this->formName;
161 - }
 161+ }
162162 function getCategoryName(){
163163 return $this->categoryName;
164164 }

Status & tagging log