r91516 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91515‎ | r91516 | r91517 >
Date:01:39, 6 July 2011
Author:reedy
Status:ok
Tags:
Comment:
Don't use an example query that gives a warning
Modified paths:
  • /trunk/extensions/CodeReview/api/ApiQueryCodeComments.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/codereview.sql
@@ -65,7 +65,7 @@
6666 cr_diff mediumblob NULL,
6767 -- Text flags: gzip,utf-8,external
6868 cr_flags tinyblob NOT NULL,
69 -
 69+
7070 primary key (cr_repo_id, cr_id)
7171 ) /*$wgDBTableOptions*/;
7272
@@ -236,10 +236,10 @@
237237 -- Type of signoff. Current values: 'inspected', 'tested'
238238 -- See CodeRevision::getPossibleFlags() (in backend/CodeRevision.php) for most up to date list
239239 cs_flag varchar(25) not null,
240 -
 240+
241241 -- Timestamp of the sign-off
242242 cs_timestamp binary(14) not null default '',
243 -
 243+
244244 -- Timestamp the sign-off was struck, or Block::infinity() if not struck
245245 cs_timestamp_struck varbinary(14) not null default 'infinity'
246246 ) /*$wgDBTableOptions*/;
Index: trunk/extensions/CodeReview/api/ApiQueryCodeComments.php
@@ -152,7 +152,7 @@
153153 public function getExamples() {
154154 return array(
155155 'api.php?action=query&list=codecomments&ccrepo=MediaWiki',
156 - 'api.php?action=query&list=codecomments&ccrepo=MediaWiki&ccprop=timestamp|user|revision|text',
 156+ 'api.php?action=query&list=codecomments&ccrepo=MediaWiki&ccprop=timestamp|user|status|text',
157157 );
158158 }
159159

Status & tagging log