r91490 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91489‎ | r91490 | r91491 >
Date:20:59, 5 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Moved 'MW_HTML_FOR_DUMP' check before config vars (localsettings may try to access them)
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -23,11 +23,6 @@
2424 exit( 1 );
2525 }
2626
27 -# This messes with dump HTML...
28 -if ( defined( 'MW_HTML_FOR_DUMP' ) ) {
29 - return;
30 -}
31 -
3227 $wgExtensionCredits['specialpage'][] = array(
3328 'path' => __FILE__,
3429 'name' => 'Flagged Revisions',
@@ -213,6 +208,11 @@
214209 # End of configuration variables.
215210 # ########
216211
 212+# This messes with dump HTML...
 213+if ( defined( 'MW_HTML_FOR_DUMP' ) ) {
 214+ return;
 215+}
 216+
217217 # Temp var
218218 $wgFlaggedRevsRCCrap = true;
219219 # Patrollable namespaces (overridden by reviewable namespaces) (don't use)

Status & tagging log