r91429 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91428‎ | r91429 | r91430 >
Date:23:36, 4 July 2011
Author:krinkle
Status:ok
Tags:
Comment:
Revert r90678 per CR
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)
  • /trunk/phase3/resources/mediawiki.page/mediawiki.page.ready.js (modified) (history)
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -21,7 +21,7 @@
2222 * @return jQuery
2323 */
2424 var tableCreate = function( header, data ) {
25 - var $table = $('<table class="mw-sortable"><thead></thead><tbody></tbody></table>'),
 25+ var $table = $('<table class="sortable"><thead></thead><tbody></tbody></table>'),
2626 $thead = $table.find('thead'),
2727 $tbody = $table.find('tbody');
2828 var $tr = $('<tr>');
Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
@@ -240,7 +240,7 @@
241241 this.order = 0;
242242 this.count = 0;
243243
244 - if ( $( this ).is( '.unsortable, .mw-unsortable' ) ) {
 244+ if ( $( this ).is( '.unsortable' ) ) {
245245 this.sortDisabled = true;
246246 }
247247
Index: trunk/phase3/resources/mediawiki.page/mediawiki.page.ready.js
@@ -9,9 +9,9 @@
1010 $( '.mw-collapsible' ).makeCollapsible();
1111
1212 /* Lazy load jquery.tablesorter */
13 - if ( $( 'table.mw-sortable, table.sortable' ).length ) {
 13+ if ( $( 'table.sortable' ).length ) {
1414 mw.loader.using( 'jquery.tablesorter', function() {
15 - $( 'table.mw-sortable, table.sortable' ).tablesorter();
 15+ $( 'table.sortable' ).tablesorter();
1616 });
1717 }
1818

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90678Switch jquery.sortable to use mw-sortable and mw-unsortable classes, to be in...hartman21:26, 23 June 2011

Status & tagging log