r91416 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91415‎ | r91416 | r91417 >
Date:19:17, 4 July 2011
Author:hashar
Status:ok
Tags:
Comment:
Revert old page navigation back to a subtitle

Please reapply to trunk for inclusion in 1.19.

reverts r85322 & r90883
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -237,11 +237,6 @@
238238 color: #7d7d7d;
239239 width: auto;
240240 }
241 -
242 -#contentSub:empty, #contentSub2:empty {
243 - display: none;
244 -}
245 -
246241 span.subpages {
247242 display: block;
248243 }
Index: trunk/phase3/skins/common/shared.css
@@ -766,17 +766,10 @@
767767 unicode-bidi: embed;
768768 }
769769
770 -#mw-revision-info, #revision-info-current, #mw-revision-nav {
 770+#mw-revision-info, #mw-revision-nav {
771771 direction: ltr;
772 - text-align: center;
773772 }
774773
775 -#mw-revision-nav {
776 - border-bottom: 1px solid #aaa;
777 - padding-bottom: 0.5em;
778 - margin-bottom: 0.5em;
779 -}
780 -
781774 /* Images */
782775 /* @noflip */div.tright, div.floatright, table.floatright {
783776 clear: right;
Index: trunk/phase3/skins/vector/screen.css
@@ -997,11 +997,6 @@
998998 color: #7d7d7d;
999999 width: auto;
10001000 }
1001 -
1002 -#contentSub:empty, #contentSub2:empty {
1003 - display: none;
1004 -}
1005 -
10061001 span.subpages {
10071002 display: block;
10081003 }
Index: trunk/phase3/includes/Article.php
@@ -1764,7 +1764,7 @@
17651765 "\n\t\t\t\t<div id=\"mw-revision-nav\">" . $cdel . wfMsgExt( 'revision-nav', array( 'escapenoentities', 'parsemag', 'replaceafter' ),
17661766 $prevdiff, $prevlink, $lnk, $curdiff, $nextlink, $nextdiff ) . "</div>\n\t\t\t";
17671767
1768 - $wgOut->addHTML( $r );
 1768+ $wgOut->setSubtitle( $r );
17691769 }
17701770
17711771 /* Caching functions */

Follow-up revisions

RevisionCommit summaryAuthorDate
r91417Revert old page navigation back to a subtitle...hashar19:19, 4 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85322Add the revision-info and revision-info-current messages directly to the page...happy-melon11:46, 4 April 2011
r90883Follow-up r85322: brion's right that some styling is desirable; so make it ce...happy-melon16:13, 27 June 2011

Status & tagging log