r91373 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91372‎ | r91373 | r91374 >
Date:15:20, 3 July 2011
Author:jan
Status:ok
Tags:
Comment:
follow-up r91199 + r91200:
* Change __DIR__ to $this->localBaseDir
* Add "public" to the new functions
Modified paths:
  • /trunk/tools/ToolserverI18N/TsIntuition.php (modified) (history)

Diff [purge]

Index: trunk/tools/ToolserverI18N/TsIntuition.php
@@ -1268,11 +1268,11 @@
12691269 * current language if missing
12701270 * @return Boolean
12711271 */
1272 - function isRTL( $code = null ) {
 1272+ public function isRTL( $code = null ) {
12731273 if ( !$code ) {
12741274 $code = $this->getLang();
12751275 }
1276 - require __DIR__ . '/language/Rtl.php';
 1276+ require $this->localBaseDir . '/language/Rtl.php';
12771277
12781278 return in_array( $code, $rtlLanguages );
12791279 }
@@ -1281,7 +1281,7 @@
12821282 * Return the correct HTML 'dir' attribute value for this language.
12831283 * @return String
12841284 */
1285 - function getDir( $code = null ) {
 1285+ public function getDir( $code = null ) {
12861286 return $this->isRTL( $code ) ? 'rtl' : 'ltr';
12871287 }
12881288 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91199Rtl information was present in Rtl.php but unused....platonides19:00, 30 June 2011
r91200Fix r91199.platonides19:03, 30 June 2011

Status & tagging log