r91345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91344‎ | r91345 | r91346 >
Date:09:05, 2 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Made FlaggedRevs use new RevisionList class (r91344) instead of revdelete hack
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/RejectConfirmationFormUI.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/RejectConfirmationFormUI.php
@@ -64,10 +64,9 @@
6565 $form .= wfMsgExt( 'revreview-reject-text-list', 'parseinline',
6666 $wgLang->formatNum( count( $rejectIds ) ), $oldRev->getTitle()->getPrefixedText() );
6767 $form .= '<ul>';
68 - // FIXME: we need a generic revision list class...this is bullshit
69 - $spRevDelete = SpecialPage::getPage( 'RevisionReview' );
70 - $spRevDelete->skin = $this->form->getUser()->getSkin(); // XXX
71 - $list = new RevDel_RevisionList( $spRevDelete, $oldRev->getTitle(), $rejectIds );
 68+
 69+ $context = RequestContext::getMain();
 70+ $list = new RevisionList( $context, $oldRev->getTitle(), $rejectIds );
7271 for ( $list->reset(); $list->current(); $list->next() ) {
7372 $item = $list->current();
7473 if ( $item->canView() ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91344* Added generic Rev_List revision listing class and refactored RevDelete_List...aaron09:04, 2 July 2011

Status & tagging log