r91342 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91341‎ | r91342 | r91343 >
Date:08:46, 2 July 2011
Author:hartman
Status:ok
Tags:
Comment:
* Fix broken post call to api in side-to-side diffs
* Fix support for side-to-side diffs in section editing

Reported in bug 29106. Patch by Michael M.
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.preview.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.preview.js
@@ -113,9 +113,9 @@
114114 };
115115 var section = $( '[name=wpSection]' ).val();
116116 if ( section != '' )
117 - postdata['rvsection'] = section;
 117+ postdata2['rvsection'] = section;
118118
119 - $.post( mw.util.wikiScript( 'api' ) + postdata2, function( data ) {
 119+ $.post( mw.util.wikiScript( 'api' ), postdata2, function( data ) {
120120 // Add diff CSS
121121 mw.loader.load( 'mediawiki.legacy.diff' );
122122 try {

Follow-up revisions

RevisionCommit summaryAuthorDate
r91343Clean up some global var leaking in WikiEditor toolbar...hartman08:54, 2 July 2011
r91347Correct for in loops on arrays....hartman09:09, 2 July 2011
r91349Adding quotes for the [rel=] stuff, since this broke one test....hartman09:17, 2 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89616Extension:WikiEditor Code quality, JSHint validation and JSPERF...krinkle23:18, 6 June 2011
r90845Bug #29106: Patch from Michael M. to address JS legacy globals in wikiEditormah19:25, 26 June 2011

Status & tagging log