r91268 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91267‎ | r91268 | r91269 >
Date:15:01, 1 July 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
properly define names for special pages, esp. for Special:Properties where this had been lost in a recent change
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_QueryPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialProperties.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialUnusedProperties.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialWantedProperties.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialProperties.php
@@ -51,6 +51,10 @@
5252 return '<p>' . wfMsg( 'smw_properties_docu' ) . "</p><br />\n";
5353 }
5454
 55+ function getName() {
 56+ return 'Properties';
 57+ }
 58+
5559 function formatResult( $skin, $result ) {
5660 $linker = smwfGetLinker();
5761
Index: trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialWantedProperties.php
@@ -49,7 +49,6 @@
5050 class SMWWantedPropertiesPage extends SMWQueryPage {
5151
5252 function getName() {
53 - /// TODO: should probably use SMW prefix
5453 return "WantedProperties";
5554 }
5655
Index: trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialUnusedProperties.php
@@ -1,7 +1,8 @@
22 <?php
33
44 /**
5 - * This special page (Special:UnusedProperties) for MediaWiki shows all unused properties.
 5+ * This special page (Special:UnusedProperties) for MediaWiki shows all unused
 6+ * properties.
67 *
78 * @file SMW_SpecialUnusedProperties.php
89 *
@@ -44,13 +45,10 @@
4546 * @ingroup SpecialPage
4647 *
4748 * @author Markus Krötzsch
48 - *
49 - * TODO: A delete button that removes all non-used property pages would be quite usefull.
5049 */
5150 class SMWUnusedPropertiesPage extends SMWQueryPage {
5251
5352 function getName() {
54 - // TODO: should probably use SMW prefix
5553 return "UnusedProperties";
5654 }
5755
Index: trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_QueryPage.php
@@ -29,10 +29,6 @@
3030 /// TODO
3131 }
3232
33 - function getName() {
34 - return "SMWQueryPage";
35 - }
36 -
3733 function isExpensive() {
3834 return false; // Disables caching for now
3935 }
@@ -120,6 +116,6 @@
121117 global $wgUser;
122118 return $wgUser->getSkin();
123119 }
124 - }
 120+ }
125121
126122 }