r91253 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91252‎ | r91253 | r91254 >
Date:08:24, 1 July 2011
Author:ialex
Status:ok
Tags:
Comment:
Call Linker::link() statically instead of getting a Skin object from $wgUser
Modified paths:
  • /trunk/phase3/includes/WikiMap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WikiMap.php
@@ -65,9 +65,6 @@
6666 * @return String: HTML link or false if the wiki was not found
6767 */
6868 public static function makeForeignLink( $wikiID, $page, $text=null ) {
69 - global $wgUser;
70 - $sk = $wgUser->getSkin();
71 -
7269 if ( !$text ) {
7370 $text = $page;
7471 }
@@ -77,7 +74,7 @@
7875 return false;
7976 }
8077
81 - return $sk->makeExternalLink( $url, $text );
 78+ return Linker::makeExternalLink( $url, $text );
8279 }
8380
8481 /**

Status & tagging log