r91242 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91241‎ | r91242 | r91243 >
Date:01:37, 1 July 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove unused parameter, update callers

Trim whitespace
Modified paths:
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -29,7 +29,7 @@
3030 global $wgLocalStylePath, $wgRequest;
3131
3232 parent::initPage( $out );
33 -
 33+
3434 // Append CSS which includes IE only behavior fixes for hover support -
3535 // this is better than including this in a CSS fille since it doesn't
3636 // wait for the CSS file to load before fetching the HTC file.
@@ -39,7 +39,7 @@
4040 htmlspecialchars( $wgLocalStylePath ) .
4141 "/{$this->stylename}/csshover{$min}.htc\")}</style><![endif]-->"
4242 );
43 -
 43+
4444 $out->addModuleScripts( 'skins.vector' );
4545 }
4646
@@ -80,7 +80,7 @@
8181 // Build additional attributes for navigation urls
8282 //$nav = $this->skin->buildNavigationUrls();
8383 $nav = $this->data['content_navigation'];
84 -
 84+
8585 if ( $wgVectorUseIconWatch ) {
8686 $mode = $this->skin->getTitle()->userIsWatching() ? 'unwatch' : 'watch';
8787 if ( isset( $nav['actions'][$mode] ) ) {
@@ -97,7 +97,7 @@
9898 if ( $section == 'views' && !( isset( $link['primary'] ) && $link['primary'] ) ) {
9999 $link['class'] = rtrim( 'collapsible ' . $link['class'], ' ' );
100100 }
101 -
 101+
102102 $xmlID = isset( $link['id'] ) ? $link['id'] : 'ca-' . $xmlID;
103103 $nav[$section][$key]['attributes'] =
104104 ' id="' . Sanitizer::escapeId( $xmlID ) . '"';
@@ -259,7 +259,7 @@
260260 /**
261261 * Render a series of portals
262262 *
263 - * @params $portals array
 263+ * @param $portals array
264264 */
265265 private function renderPortals( $portals ) {
266266 // Force the rendering of the following portals
Index: trunk/phase3/skins/MonoBook.php
@@ -31,13 +31,13 @@
3232 parent::setupSkinUserCss( $out );
3333
3434 $out->addModuleStyles( 'skins.monobook' );
35 -
 35+
3636 // Ugh. Can't do this properly because $wgHandheldStyle may be a URL
3737 if( $wgHandheldStyle ) {
3838 // Currently in testing... try 'chick/main.css'
3939 $out->addStyle( $wgHandheldStyle, 'handheld' );
4040 }
41 -
 41+
4242 // TODO: Migrate all of these
4343 //$out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
4444 //$out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
@@ -103,7 +103,7 @@
104104 </div>
105105 </div></div>
106106 <div id="column-one"<?php $this->html('userlangattributes') ?>>
107 -<?php $this->cactions( $this->skin ); ?>
 107+<?php $this->cactions(); ?>
108108 <div class="portlet" id="p-personal">
109109 <h5><?php $this->msg('personaltools') ?></h5>
110110 <div class="pBody">
@@ -225,7 +225,7 @@
226226 *
227227 * @param $skin Skin
228228 */
229 - function cactions( Skin $skin ) {
 229+ function cactions() {
230230 ?>
231231 <div id="p-cactions" class="portlet">
232232 <h5><?php $this->msg('views') ?></h5>
@@ -233,7 +233,7 @@
234234 <ul><?php
235235 foreach($this->data['content_actions'] as $key => $tab) {
236236 $linkAttribs = array( 'href' => $tab['href'] );
237 -
 237+
238238 if( isset( $tab["tooltiponly"] ) && $tab["tooltiponly"] ) {
239239 $title = Linker::titleAttrib( "ca-$key" );
240240 if ( $title !== false ) {
@@ -243,7 +243,7 @@
244244 $linkAttribs += Linker::tooltipAndAccesskeyAttribs( "ca-$key" );
245245 }
246246 $linkHtml = Html::element( 'a', $linkAttribs, $tab['text'] );
247 -
 247+
248248 /* Surround with a <li> */
249249 $liAttribs = array( 'id' => Sanitizer::escapeId( "ca-$key" ) );
250250 if( $tab['class'] ) {
Index: trunk/phase3/skins/Modern.php
@@ -63,7 +63,7 @@
6464 <div id="mw_main">
6565 <div id="mw_contentwrapper">
6666 <!-- navigation portlet -->
67 -<?php $this->cactions( $skin ); ?>
 67+<?php $this->cactions(); ?>
6868
6969 <!-- content -->
7070 <div id="mw_content">

Status & tagging log