r91239 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91238‎ | r91239 | r91240 >
Date:00:16, 1 July 2011
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
fixing size for half barnstar, making spelling consistant (other entries are all US spelling)
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.defaultOptions.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.defaultOptions.js
@@ -129,7 +129,8 @@
130130 descr: 'The Half Barnstar is awarded for excellence in cooperation, especially for productive editing with someone who holds an opposing viewpoint.',
131131 header: 'A barnstar for you!',
132132 title: 'The Half Barnstar',
133 - image: 'Halfstar Hires.png'
 133+ image: 'Halfstar Hires.png',
 134+ imageSize: '60px'
134135 },
135136 'minor': {
136137 fields: [ 'message' ],
@@ -323,7 +324,7 @@
324325 'pie': {
325326 fields: [ 'header', 'message' ],
326327 option: 'Pie',
327 - descr: 'Pies can be filled with a wide variety of sweet or savoury ingredients. Popular varieties include apple, cherry, peach, chocolate, and pecan.',
 328+ descr: 'Pies can be filled with a wide variety of sweet or savory ingredients. Popular varieties include apple, cherry, peach, chocolate, and pecan.',
328329 header: 'A pie for you!',
329330 image: 'A very beautiful Nectarine Pie.jpg',
330331 imageSize: '120px'

Comments

#Comment by Reedy (talk | contribs)   00:27, 1 July 2011

Shouldn't this probably be in the i18n files so they can be localised...?

#Comment by Kaldari (talk | contribs)   00:30, 1 July 2011

That's planned for v1.1.

#Comment by Reedy (talk | contribs)   00:31, 1 July 2011

Ah :)

Status & tagging log