r91209 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91208‎ | r91209 | r91210 >
Date:19:44, 30 June 2011
Author:reedy
Status:deferred
Tags:
Comment:
Goddamn americani[ZS]ation and stuff
Modified paths:
  • /trunk/extensions/MetricsReporting/ApiAnalyticsBase.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/ApiAnalyticsBase.php
@@ -40,7 +40,7 @@
4141
4242 $query['conds']['date'] = $params['months'];
4343
44 - if ( $params['normalised'] ) {
 44+ if ( $params['normalized'] ) {
4545 // Do data normalisation stuffs here
4646 }
4747 // if/switch on $params['data']
@@ -90,13 +90,13 @@
9191 foreach( $res as $row ) {
9292 $item = array();
9393 foreach( $fields as $field ) {
94 - $item[$field] = $row->$field;
 94+ $item[$field] = $row->$$field;
9595 }
9696 $data[] = $item;
9797 }
9898
99 - $result->setIndexedTagName( $data, 'metric' );
100 - $result->addValue( 'quermetricy', $this->getModuleName(), $data );
 99+ $result->setIndexedTagName( $data, 'data' );
 100+ $result->addValue( 'metric', $this->getModuleName(), $data );
101101 }
102102
103103 protected abstract function getQueryInfo();
@@ -116,7 +116,7 @@
117117 ApiBase::PARAM_TYPE => 'string',
118118 ApiBase::PARAM_REQUIRED => true,
119119 ),
120 - 'normalized' => 'bool',
 120+ 'normalized' => false,
121121 'data' => array(
122122 ApiBase::PARAM_DFLT => 'timeseries',
123123 ApiBase::PARAM_ISMULTI => true,

Status & tagging log