r91192 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91191‎ | r91192 | r91193 >
Date:18:16, 30 June 2011
Author:demon
Status:ok
Tags:
Comment:
Move $wgFeedClasses to DefaultSettings where they belong. This has been bothering me for years.

Somewhat in the spirit of r87637, except I didn't put them in WebStart because that doesn't make sense.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Defines.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Defines.php
@@ -85,16 +85,6 @@
8686 define( 'NS_IMAGE_TALK', NS_FILE_TALK );
8787 /**@}*/
8888
89 -/**
90 - * Available feeds objects
91 - * Should probably only be defined when a page is syndicated ie when
92 - * $wgOut->isSyndicated() is true
93 - */
94 -$wgFeedClasses = array(
95 - 'rss' => 'RSSFeed',
96 - 'atom' => 'AtomFeed',
97 -);
98 -
9989 /**@{
10090 * Cache type
10191 */
Index: trunk/phase3/includes/DefaultSettings.php
@@ -4373,6 +4373,16 @@
43744374 $wgOverrideSiteFeed = array();
43754375
43764376 /**
 4377+ * Available feeds objects
 4378+ * Should probably only be defined when a page is syndicated ie when
 4379+ * $wgOut->isSyndicated() is true
 4380+ */
 4381+$wgFeedClasses = array(
 4382+ 'rss' => 'RSSFeed',
 4383+ 'atom' => 'AtomFeed',
 4384+);
 4385+
 4386+/**
43774387 * Which feed types should we provide by default? This can include 'rss',
43784388 * 'atom', neither, or both.
43794389 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87637Centralise the minimum-required-php-version in a MW_MIN_PHP_VERSION constant ...happy-melon15:16, 7 May 2011

Status & tagging log