r91188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91187‎ | r91188 | r91189 >
Date:17:43, 30 June 2011
Author:btongminh
Status:ok
Tags:
Comment:
Follow-up r81536: Properly extract ($dstZone, $dstRel) from the triplet.
Modified paths:
  • /trunk/phase3/includes/filerepo/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/LocalFile.php
@@ -1981,8 +1981,11 @@
19821982 $cleanupBatch = array();
19831983
19841984 foreach ( $storeStatus->success as $i => $success ) {
 1985+ // Check if this item of the batch was successfully copied
19851986 if ( $success ) {
1986 - $cleanupBatch[] = array( $storeBatch[$i][1], $storeBatch[$i][1] );
 1987+ // Item was successfully copied and needs to be removed again
 1988+ // Extract ($dstZone, $dstRel) from the batch
 1989+ $cleanupBatch[] = array( $storeBatch[$i][1], $storeBatch[$i][2] );
19871990 }
19881991 }
19891992 $this->file->repo->cleanupBatch( $cleanupBatch );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81536(bug 19751) Filesystem is now checked during image undeletion...btongminh20:54, 4 February 2011

Status & tagging log