r91178 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91177‎ | r91178 | r91179 >
Date:15:20, 30 June 2011
Author:robin
Status:ok
Tags:
Comment:
Simpler code
Modified paths:
  • /trunk/phase3/includes/Pager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Pager.php
@@ -945,7 +945,7 @@
946946 * A navigation bar with images
947947 */
948948 function getNavigationBar() {
949 - global $wgStylePath, $wgContLang, $wgLang, $wgBetterDirectionality;
 949+ global $wgStylePath;
950950
951951 if ( !$this->isNavigationBarShown() ) {
952952 return '';
@@ -970,8 +970,7 @@
971971 'next' => 'arrow_disabled_right_25.png',
972972 'last' => 'arrow_disabled_last_25.png',
973973 );
974 - $isRTL = ( $wgBetterDirectionality ? $wgLang->isRTL() : $wgContLang->isRTL() );
975 - if( $isRTL ) {
 974+ if( wfUILang()->isRTL() ) {
976975 $keys = array_keys( $labels );
977976 $images = array_combine( $keys, array_reverse( $images ) );
978977 $disabledImages = array_combine( $keys, array_reverse( $disabledImages ) );

Status & tagging log