r91174 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91173‎ | r91174 | r91175 >
Date:14:53, 30 June 2011
Author:ialex
Status:ok
Tags:
Comment:
Much, much easier to call Linker::link() statically instead of grabbing a Skin from $wgUser
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -3523,9 +3523,7 @@
35243524 }
35253525 $title = self::getGroupPage( $group );
35263526 if( $title ) {
3527 - global $wgUser;
3528 - $sk = $wgUser->getSkin();
3529 - return $sk->link( $title, htmlspecialchars( $text ) );
 3527+ return Linker::link( $title, htmlspecialchars( $text ) );
35303528 } else {
35313529 return $text;
35323530 }

Status & tagging log