r91171 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91170‎ | r91171 | r91172 >
Date:14:44, 30 June 2011
Author:robin
Status:deferred
Tags:
Comment:
Add lang & dir attributes for the source text (English) in Special:Translate
Modified paths:
  • /trunk/extensions/Translate/utils/MessageTable.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageTable.php
@@ -132,7 +132,7 @@
133133 $rclasses = array_merge ( $mespa, array( 'class' => 'translated' ) );
134134 } else {
135135 $message = $original;
136 - $rclasses = array( 'class' => 'untranslated' );
 136+ $rclasses = array( 'lang' => 'en', 'dir' => 'ltr', 'class' => 'untranslated' );
137137 }
138138
139139 global $wgLang;
@@ -160,7 +160,8 @@
161161 if ( $this->reviewMode && $original !== $message ) {
162162 $output .= Xml::tags( 'tr', array( 'class' => 'orig' ),
163163 Xml::tags( 'td', array( 'rowspan' => '2' ), $leftColumn ) .
164 - Xml::tags( 'td', null, TranslateUtils::convertWhiteSpaceToHTML( $original ) )
 164+ Xml::tags( 'td', array( 'lang' => 'en', 'dir' => 'ltr' ),
 165+ TranslateUtils::convertWhiteSpaceToHTML( $original ) )
165166 );
166167
167168 $output .= Xml::tags( 'tr', array( 'class' => 'new' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r96161* Avoid CSS border bug in Chrome where 'left' displays at the right for td el...robin22:46, 2 September 2011

Status & tagging log