r91165 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91164‎ | r91165 | r91166 >
Date:11:48, 30 June 2011
Author:robin
Status:ok
Tags:
Comment:
Fix r90872: put everything under $wgBetterDirectionality so it doesn't break the divs
Modified paths:
  • /trunk/extensions/LiquidThreads/pages/TalkpageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/pages/TalkpageView.php
@@ -274,11 +274,11 @@
275275 global $wgLang, $wgBetterDirectionality;
276276 if( $wgBetterDirectionality ) {
277277 // This closes the div of mw-content-ltr/rtl containing lang and dir attributes
278 - $this->output->addHTML( Html::closeElement( 'div' ) );
 278+ $this->output->addHTML(
 279+ Html::closeElement( 'div' ) . Html::openElement( 'div',
 280+ array( 'class' => 'lqt-talkpage', 'lang' => $wgLang->getCode(), 'dir' => wfUILang()->getDir() )
 281+ ) );
279282 }
280 - $this->output->addHTML( Html::openElement( 'div',
281 - array( 'class' => 'lqt-talkpage', 'lang' => $wgLang->getCode(), 'dir' => wfUILang()->getDir() )
282 - ) );
283283
284284 $html = '';
285285

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90872LiquidThreads: better support for different directionality (LTR/RTL): make ev...robin12:25, 27 June 2011

Status & tagging log