r91131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91130‎ | r91131 | r91132 >
Date:22:37, 29 June 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow up r91072. This is indeed not needed.
Modified paths:
  • /trunk/phase3/includes/Xml.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Xml.php
@@ -863,7 +863,7 @@
864864 public function addOption( $name, $value = false ) {
865865 // Stab stab stab
866866 $value = ($value !== false) ? $value : $name;
867 - $this->options[] = array( $name => $value ); //Xml::option( $name, $value, $value === $this->default );
 867+ $this->options[] = array( $name => $value );
868868 }
869869
870870 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91072Delay expansion of XmlSelect options until getting the HTML....platonides14:15, 29 June 2011

Status & tagging log