r91116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91115‎ | r91116 | r91117 >
Date:21:54, 29 June 2011
Author:reedy
Status:deferred
Tags:
Comment:
Using a global when needed is helpful
Modified paths:
  • /trunk/extensions/MetricsReporting/ApiAnalytics.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/ApiAnalytics.php
@@ -87,7 +87,8 @@
8888 $querySeparator = str_repeat( '--- ', 12 );
8989 $moduleSeparator = str_repeat( '*** ', 14 );
9090 $msg .= "\n$querySeparator Analytics: Metrics $querySeparator\n\n";
91 - $msg .= $this->makeHelpMsgHelper( $this->metricModules, 'metric' );
 91+ global $wgMetricAPIModules;
 92+ $msg .= $this->makeHelpMsgHelper( $wgMetricAPIModules, 'metric' );
9293 $msg .= "\n\n$moduleSeparator Modules: continuation $moduleSeparator\n\n";
9394
9495 return $msg;

Status & tagging log