r91114 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91113‎ | r91114 | r91115 >
Date:21:51, 29 June 2011
Author:platonides
Status:ok
Tags:
Comment:
We don't need $skin as a local variable.
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -70,7 +70,7 @@
7171 * @access private
7272 */
7373 function execute() {
74 - $this->skin = $skin = $this->data['skin'];
 74+ $this->skin = $this->data['skin'];
7575
7676 // Suppress warnings to prevent notices about missing indexes in $this->data
7777 wfSuppressWarnings();
@@ -103,7 +103,7 @@
104104 </div>
105105 </div></div>
106106 <div id="column-one"<?php $this->html('userlangattributes') ?>>
107 -<?php $this->cactions( $skin ); ?>
 107+<?php $this->cactions( $this->skin ); ?>
108108 <div class="portlet" id="p-personal">
109109 <h5><?php $this->msg('personaltools') ?></h5>
110110 <div class="pBody">

Status & tagging log