r91094 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91093‎ | r91094 | r91095 >
Date:18:40, 29 June 2011
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Fix for r91081, I think he meant $content, not $cont.
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -274,7 +274,7 @@
275275 }
276276 // Render portals
277277 foreach ( $portals as $name => $content ) {
278 - if ( $cont === false )
 278+ if ( $content === false )
279279 continue;
280280
281281 echo "\n<!-- {$name} -->\n";
Index: trunk/phase3/skins/MonoBook.php
@@ -180,7 +180,7 @@
181181 if ( !isset( $sidebar['LANGUAGES'] ) ) $sidebar['LANGUAGES'] = true;
182182
183183 foreach ($sidebar as $boxName => $cont) {
184 - if ( $cont === false )
 184+ if ( $content === false )
185185 continue;
186186
187187 if ( $boxName == 'SEARCH' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r91095Followup r91094: monobook wasn't broken, but I broke it. Rename to content he...demon18:44, 29 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91081Make a sidebar key with value false mean 'skip this header'....platonides17:20, 29 June 2011

Comments

#Comment by Krinkle (talk | contribs)   18:41, 29 June 2011

Yes, but only in Vector ;-)

Status & tagging log