r91073 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91072‎ | r91073 | r91074 >
Date:15:05, 29 June 2011
Author:ialex
Status:deferred
Tags:
Comment:
Calling startExternalParse() just before transformMsg() won't change anything since it's also called by transformMsg(); instead pass the Title object to transformMsg()
Modified paths:
  • /trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.php (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.smw15.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.smw15.php
——@@ -120,8 +120,7 @@
121121 // Take care at least of some templates -- for better template support use #ask
122122 $parser = new Parser();
123123 $parserOptions = new ParserOptions();
124 - $parser->startExternalParse( $wgTitle, $parserOptions, OT_HTML );
125 - $rawquery = $parser->transformMsg( $rawquery, $parserOptions );
 124+ $rawquery = $parser->transformMsg( $rawquery, $parserOptions, $wgTitle );
126125
127126 wfProfileIn( 'SMWNotifyProcessor::createNotify (SMW)' );
128127 $sStore = NMStorage::getDatabase();
Index: trunk/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.php
——@@ -120,8 +120,7 @@
121121 // Take care at least of some templates -- for better template support use #ask
122122 $parser = new Parser();
123123 $parserOptions = new ParserOptions();
124 - $parser->startExternalParse( $wgTitle, $parserOptions, OT_HTML );
125 - $rawquery = $parser->transformMsg( $rawquery, $parserOptions );
 124+ $rawquery = $parser->transformMsg( $rawquery, $parserOptions, $wgTitle );
126125
127126 wfProfileIn( 'SMWNotifyProcessor::createNotify (SMW)' );
128127 $sStore = NMStorage::getDatabase();