r91071 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91070‎ | r91071 | r91072 >
Date:13:45, 29 June 2011
Author:platonides
Status:ok
Tags:
Comment:
Make BitmapMetadataHandlerTest incomplete if $wgShowEXIF is not set.
It was throwing 'MWException: Internal error: exif_read_data not present. $wgShowEXIF may be incorrectly set or not checked by an extension.'
Fixed typo in LocalSettings.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php
@@ -9,7 +9,11 @@
1010 * translation (to en) where XMP should win.
1111 */
1212 public function testMultilingualCascade() {
13 -
 13+ global $wgShowEXIF;
 14+ if ( !$wgShowEXIF ) {
 15+ $this->markTestIncomplete( "This test needs the exif extension." );
 16+ }
 17+
1418 $meta = BitmapMetadataHandler::Jpeg( dirname( __FILE__ ) .
1519 '/Xmp-exif-multilingual_test.jpg' );
1620
Index: trunk/phase3/includes/DefaultSettings.php
@@ -354,7 +354,7 @@
355355 * Requires PHP's EXIF extension: http://www.php.net/manual/en/ref.exif.php
356356 *
357357 * NOTE FOR WINDOWS USERS:
358 - * To enable EXIF functions, add the folloing lines to the
 358+ * To enable EXIF functions, add the following lines to the
359359 * "Windows extensions" section of php.ini:
360360 *
361361 * extension=extensions/php_mbstring.dll

Status & tagging log